-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Optimized date parsing for numbers #132462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I didn't realize dates were provided as number instead of string when indexing via OTLP.
… as a number This improves the ingestion performance in Elasticsearch as it can leverage an optimized code path for date parsing. See elastic/elasticsearch#132462 This is not a breaking change because we are using the `date` field type for metrics. Supporting a more granular date format, such as `date_nanos` doesn't seem sensible for metrics as it would cause a big storage overhead. Most other metrics data stores also don't support more granularity than milliseconds.
|
Well, today, the Elasticsearch exporter in the OTel collector sets an epoch millis timestamp with a fractional for the But for metrics in particular, I don't think this level of granularity is useful and we're using the |
… as a number (#41811) This improves the ingestion performance in Elasticsearch as it can leverage an optimized code path for date parsing. See elastic/elasticsearch#132462 This is not a breaking change because we are using the `date` field type for metrics. Supporting a more granular date format, such as `date_nanos` doesn't seem sensible for metrics as it would cause a big storage overhead. Most other metrics data stores also don't support more granularity than milliseconds. --------- Co-authored-by: Carson Ip <[email protected]>
Optimized parsing for
dateanddate_nanosif the data is provided as epoch millis.